summaryrefslogtreecommitdiff
path: root/src/eris.lisp
diff options
context:
space:
mode:
Diffstat (limited to 'src/eris.lisp')
-rw-r--r--src/eris.lisp48
1 files changed, 28 insertions, 20 deletions
diff --git a/src/eris.lisp b/src/eris.lisp
index d86934b..ba04c03 100644
--- a/src/eris.lisp
+++ b/src/eris.lisp
@@ -169,11 +169,12 @@ versioning bytes are not supported by eris-cl."
(defmacro output-block (ref-vector)
`(let ((reference (compute-reference block)))
(if hash-output
- (unless (gethash reference *output-hashmap*)
- (let ((rk (encrypt-block block secret reference)))
- (vector-push-extend rk ,ref-vector)
- (setf (gethash reference *output-hashmap*) t)
- (funcall output-function block (reference rk))))
+ (if (gethash reference *output-hashmap*)
+ block
+ (let ((rk (encrypt-block block secret reference)))
+ (vector-push-extend rk ,ref-vector)
+ (setf (gethash reference *output-hashmap*) t)
+ (funcall output-function block (reference rk))))
(let ((rk (encrypt-block block secret reference)))
(vector-push-extend rk ,ref-vector)
(funcall output-function block (reference rk))))))
@@ -212,13 +213,16 @@ guarantee that a reference is only output once."))
(setf input (pad input block-size))
(let ((reference-vector (make-array 16 :adjustable t :fill-pointer 0))
- (*output-hashmap* (if hash-output (make-hash-table :test #'equalp) nil)))
- (loop for block = (make-array block-size :element-type 'octet :initial-element 0)
- ;; then (output-block reference-vector)
- for i = 0 then (incf i)
+ (*output-hashmap* (if hash-output (make-hash-table :test #'equalp) nil))
+ (block (make-array block-size :element-type 'octet :initial-element 0)))
+ (declare (type octet-vector block))
+ (loop for i = 0 then (incf i)
until (= (length input) (* i block-size))
do (progn (replace block input :start2 (* i block-size))
- (setf block (output-block reference-vector))))
+ (setf block (output-block reference-vector))
+ (fill block 0)))
+ ;; always bzero the buffer; this is unoptimal (it only needs to be zeroed out to eliminate trailing junk)
+ ;; TODO: consider removing this entire function and replacing it with an octet stream
(eris-create-tree reference-vector block-size output-function :hash-output hash-output)))
(defmethod eris-encode ((input stream) block-size output-function &key (secret null-secret) hash-output)
@@ -227,14 +231,15 @@ guarantee that a reference is only output once."))
(type function output-function)
(type (octet-vector 32) secret))
(let ((reference-vector (make-array 16 :adjustable t :fill-pointer 0))
- (*output-hashmap* (if hash-output (make-hash-table :test #'equalp) nil)))
- (loop for block = (make-array block-size :element-type 'octet :initial-element 0)
- ;;then (output-block reference-vector)
- for bytes-read = (read-sequence block input)
+ (*output-hashmap* (if hash-output (make-hash-table :test #'equalp) nil))
+ (block (make-array block-size :element-type 'octet :initial-element 0)))
+ (declare (type octet-vector block))
+ (loop for bytes-read = (read-sequence block input)
for i = 0 then (incf i)
if (< bytes-read block-size)
- do (setf (aref block bytes-read) #x80)
- do (setf block (output-block reference-vector))
+ do (progn (setf (aref block bytes-read) #x80)
+ (fill block 0 :start (1+ bytes-read))) ;; bzero the buffer here to eliminate trailing junk
+ do (progn (setf block (output-block reference-vector)))
until (< bytes-read block-size))
(eris-create-tree reference-vector block-size output-function :hash-output hash-output)))
@@ -255,14 +260,17 @@ guarantee that a reference is only output once."))
;; loop across the key-reference vector and build the tree
(loop with block = (make-array block-size :element-type 'octet :initial-element 0)
for rk across reference-vector
- with i = 0
+ with i = 0
when (eql i block-keys)
- do (setf block (output-internal-block reference-vector-l nonce)
- i 0)
+ do (progn (setf block (output-internal-block reference-vector-l nonce))
+ (setf i 0)
+ (fill block 0))
do (progn (reference-pair-to-octets rk block (* 64 i))
(incf i))
finally (unless (zerop i)
- ;; If i is zero, then the amount of blocks is just right. Otherwise add a final unfinished block.
+ ;; If i is zero, then the amount of blocks is just
+ ;; right. Otherwise add a final unfinished block.
+
(output-internal-block reference-vector-l nonce)))
(setf reference-vector reference-vector-l)
(setf reference-vector-l (make-array 16 :adjustable t :fill-pointer 0)))))